search

mysterioustrousers / MTMigration

Manages blocks of code that only need to run once on version updates in iOS apps.
BSD 2-Clause "Simplified" License
914 stars 50 forks source link

Application Update Block #6

Closed fechu closed 10 years ago

fechu commented 11 years ago

As i mentioned in Issue #5 I implemented a method that executes a block on every update of the application. As I'm not a native english speaker I would appreciate if you could go over the changes in the README and fix errors. I'm also not 100% sure what the new method should be called. If you have any better Ideas feel free to change the method name.

pwightman commented 11 years ago

I'm a stickler for grammar/typos and everything looks good, so well done! The only change I would make is to change the method name to applicationUpdateBlock. So if you switch it to that (and update the README and tests with the change too) then I'll merge it in!

Thanks!

fechu commented 11 years ago

Alright! I'll do that as soon as possible. Thx!

fechu commented 11 years ago

I changed the method name to applicationUpdateBlock and added another unit test.

pwightman commented 11 years ago

Awesome! Sorry for the delay, I'll merge this in a bit. — Sent from Mailbox for iPhone

On Wed, Jul 24, 2013 at 1:57 PM, Sandro Meier notifications@github.com wrote:

I changed the method name to applicationUpdateBlock and added another unit test.

Reply to this email directly or view it on GitHub: https://github.com/mysterioustrousers/MTMigration/pull/6#issuecomment-21511633

fechu commented 10 years ago

What about merging? :smile: I still have to use my own fork. I would like to use the main repo.

pwightman commented 10 years ago

Yep, sorry for the delay! I'll make a new cocoapods version too.

fechu commented 10 years ago

Thanks. Awesome. Tell me if you need help. On 16.09.2013, at 05:19, Parker notifications@github.com wrote:

Yep, sorry for the delay! I'll make a new cocoapods version too.

— Reply to this email directly or view it on GitHub.

pwightman commented 10 years ago

3 tests aren't passing after this commit, were they passing for you before merging?

fechu commented 10 years ago

Strange. I will try that too, and let you know what happened.

fechu commented 10 years ago

I looked into it and it's strange. I could fix one of the failing tests. I don't know why that didn't happen earlier. The reset method did only reset the lastMigrationVersion and not the lastAppVersion.

fechu commented 10 years ago

I just found the reason for the second failing unit test. It's commit 207f710114b0. So actually you made the test failing. ;-) I will fix it in the next few minutes and update the pull request.

pwightman commented 10 years ago

Oh, haha, curse it all! Sorry about that. I'll take a look here in a minute too, just about home.

— Sent from Mailbox for iPhone

On Wed, Oct 23, 2013 at 12:15 PM, Sandro Meier notifications@github.com wrote:

I just found the reason for the second failing unit test. It's commit 207f710114b0. So actually you made the test failing. ;-) I will fix it in the next few minutes and update the pull request.

Reply to this email directly or view it on GitHub: https://github.com/mysterioustrousers/MTMigration/pull/6#issuecomment-26929527

fechu commented 10 years ago

As you already merged this pull request, I couldn't push another commit to it. See #8 for the new pull request.