search

mysteriumnetwork / node

Mysterium Network Node - official implementation of distributed VPN network (dVPN) protocol
https://mysterium.network
GNU General Public License v3.0
1.1k stars 314 forks source link

Do not expose user IP ever (activate kill-switch instead) #4653

Open portalsdevs opened 2 years ago

portalsdevs commented 2 years ago

Followup to https://github.com/mysteriumnetwork/node/issues/4643

At this moment, if "something" goes wrong, and node enters into IP_NOT_CHANGED state, the IP address of consumer is exposed (and official Mysterium Android app treats IP_NOT_CHANGED as protected connection state https://github.com/mysteriumnetwork/mysterium-vpn-mobile/blob/50eaccb23a726f0caf3eb14bf09b116b23bdc08d/android/app/src/main/java/updated/mysterium/vpn/ui/base/BaseActivity.kt#L216 )

I any case, if consumer IP address is about to be exposed, node should activate kill-switch and enter the ON_HOLD state.

veldspar commented 2 years ago

can confirm - tried to withdraw from node to register another nodes identity, transaction got confirmed by sender node but does not show up in either the tx window of NodeUI or on polygonscan