search

mysterymagination / adventures-of-mooty-wort

An Undum eval tale, short and sweet
MIT License
0 stars 0 forks source link

combat window doesn't fit between inv and equipment side panels on all displays #40

Closed mysterymagination closed 3 years ago

mysterymagination commented 3 years ago

the positioning of the side panels is based on em margins, I think, and they have fixed size. The positioning of the combat modal is just horizontal center but the width is given as a percentage of the parent container, which is currently the whole page so basically just vw. The current settings work for my laptop but not my desktop monitor X|

I guess we need to somehow add a constraint on top of the width perc that keeps the modal bounded by the side panels... really wish HTML/CSS actually had constraint layout of some sort. Maybe em based margin on top of the the width perc? I'm currently centering with margin auto, so we'd have to give that up but maybe it doesn't matter if we follow the example of the side panels nad just move in further (by side panel's width)?

mysterymagination commented 3 years ago

changed position of combat modal to fixed and use left and right positioning as 15em. It's not great but pretty ok on various window sizes; TBD if if still works nicely on a widescreen display. I moved the side panels to left and right extrema to make it easier to land someplace in between 'em XD