search

mysticatea / cpx

A cli tool to watch and copy file globs.
MIT License
524 stars 36 forks source link

Add Support for TypeScript #36

Open alan-agius4 opened 7 years ago

alan-agius4 commented 7 years ago

Hi,

Are you willing to accept TypeScript typings within the repo itself?

This will make it more convenient for typescript users (and suggested by typescript) to provide typings with the repository itself, rather than another repo (such as DefinitelyTyped).

Are you willing to have a pull request for this?

I will be happy to create typing for this library myself if you agree.

Thanks!

dominique-mueller commented 6 years ago

Looks like types already exist (under @types/cpx) - but I would also prefer the typings coming with the package itself.

alan-agius4 commented 6 years ago

Indeed by for far the library author seems to have no interest in this.

dominique-mueller commented 6 years ago

@mysticatea Would you accept a PR for that?

mysticatea commented 6 years ago

I'm sorry that I'm inactive on this package.

Yeah, I will accept a PR for that.

I love TypeScript. So I want to rewrite my OSS packages with TypeScript if I got enough time. Actually, there are WIP branches on npm-run-all and bre. Currently, I'm writing a ton of new rules on eslint-plugin-node to support new things of Node.js 10. I will come back to rewrite cpx with TypeScript after that completed.