New rule no-uneccessary-globals

mysticatea / eslint-plugin-eslint-comments

Additional ESLint rules for directive comments of ESLint.

https://mysticatea.github.io/eslint-plugin-eslint-comments/

MIT License

354 stars 44 forks source link

New rule no-uneccessary-globals #20

Closed hornta closed 5 years ago

hornta commented 5 years ago

We do have a lot of / globals window / or / globals require / in ourcode despite those being recognized as globals from eslints env and globals config. I suggest having a rule that reports on already existing globals in comments.

mysticatea commented 5 years ago

Thank you for this proposal!

However, we cannot implement this without some change of ESLint core. And I think that no-redeclare rule should do this because:

this is a kind of redeclaration.
no-unused-vars rule reports unused variables that /*globals*/ comments defined.

I opened an issue: https://github.com/eslint/eslint/issues/11370

Please track that issue.