search

mysticatea / eslint-plugin-eslint-comments

Additional ESLint rules for directive comments of ESLint.
https://mysticatea.github.io/eslint-plugin-eslint-comments/
MIT License
361 stars 45 forks source link

`no-unused-disable` missing in recommended #22

Closed e110c0 closed 5 years ago

e110c0 commented 5 years ago

while the documentation lists no-unused-disable in the recommended section, it is not activated by just using extends: ['plugin:eslint-comments/recommended']

Not sure which behaviour is favourable, but config and documentation should match.

mysticatea commented 5 years ago

What is "the recommended section"? The recommended config doesn't include no-unused-disable rule intentionally: https://mysticatea.github.io/eslint-plugin-eslint-comments/#%F0%9F%93%96-usage

e110c0 commented 5 years ago

sorry, didn't write clearly. What I meant is that no-unused-disable is part of the best practice section in the documentation. Hence I would expect it to be enabled in the recommended config.

Not sure how the link explains that it is not included intentionally

mysticatea commented 5 years ago

Thank you for the explanation.

"Best Practice" doesn't mean be included in the recommended config. For example, Core rule list has a ton of best practice rules, but eslint:recommended includes a few of those. They indicate the recommended rules by "✔" mark in the list.

Similarly, I indicate the recommended rules by "★" mark in the rule list.

e110c0 commented 5 years ago

ah, got it. Sorry I missed that. Thanks for the explanation