search

mysticatea / eslint-plugin-eslint-comments

Additional ESLint rules for directive comments of ESLint.
https://mysticatea.github.io/eslint-plugin-eslint-comments/
MIT License
361 stars 46 forks source link

require-description: previous line comment check #56

Open JasonMore opened 3 years ago

JasonMore commented 3 years ago

I figured I'd give multi line comments for require-description a try. It seems to work?

JasonMore commented 3 years ago

@mysticatea any thoughts on this PR?

JasonMore commented 3 years ago

@mysticatea we have been using this a few months now with great successs

JasonMore commented 3 years ago

@goloroden yeah I've just been running a local version of this myself. However I've recently discovered https://www.npmjs.com/package/patch-package which is nice too

bossley9 commented 2 years ago

@mysticatea any updates?

ehellman commented 2 years ago

Would love to get this merged too, I have written a standalone plugin for this that we are using at the moment but feels like the functionality should live here

tylerlaprade commented 1 year ago

Comments on different lines can be moved around by prettier or other eslint rules. The only way to guarantee you tie your description to your eslint comment is by using -- to include the comment on the same line.

MichaelDeBoey commented 1 year ago

Hi @JasonMore!

Since this repo is unmaintained, you might want to re-open this PR in the @eslint-community fork https://github.com/eslint-community/eslint-plugin-eslint-comments

For more info about why we created this organization, you can read https://eslint.org/blog/2023/03/announcing-eslint-community-org