search

mysticatea / eslint-plugin-eslint-comments

Additional ESLint rules for directive comments of ESLint.
https://mysticatea.github.io/eslint-plugin-eslint-comments/
MIT License
361 stars 46 forks source link

Merge this with eslint-plugin-canonical #65

Open gajus opened 3 years ago

gajus commented 3 years ago

Hey @mysticatea,

Would you be oppose if the rules in this plugin were merged into https://github.com/gajus/eslint-plugin-canonical this plugin?

I am trying to consolidate efforts around some of the more niche plugin maintenance to make it easier to handle upgrades such as the requirements moving from ESLint v7 to v8 support.

I would do all the work.

Vages commented 3 years ago

You may already know this, but in case not: This project is MIT licensed, so copying the entire package – or parts of it – is probably within the boundaries of the law and developer courtesy (as long as you follow the terms of the license): https://github.com/mysticatea/eslint-plugin-eslint-comments/blob/master/LICENSE

Looking forward to seeing the rules in eslint-plugin-canonical!

gajus commented 3 years ago

It's less about the license, and more about making sure that this would be a value additive contribution. If @mysticatea intends to continue working on this project, then it makes little sense to copy them to Canonical.