search

mysticatea / eslint-plugin-eslint-comments

Additional ESLint rules for directive comments of ESLint.
https://mysticatea.github.io/eslint-plugin-eslint-comments/
MIT License
354 stars 44 forks source link

`no-unused-disable` doesn't work with flat config #79

Open teppeis opened 9 months ago

teppeis commented 9 months ago

This rule is implemented by patching Linter, which seems to be causing this problem with new flat config.

The flat config allows reportUnusedDisableDirectives to be included in shareable config. The new RFC will also allow for more configuration flexibility (in ESLint v9 ?).

So it would be good to make this rule deprecated in the future.

MichaelDeBoey commented 8 months ago

Hi @teppeis!

Since this repo is unmaintained, you might want to re-open this issue in the @eslint-community fork https://github.com/eslint-community/eslint-plugin-eslint-comments

For more info about why we created this organization, you can read https://eslint.org/blog/2023/03/announcing-eslint-community-org

teppeis commented 8 months ago

@MichaelDeBoey I've reopened there: https://github.com/eslint-community/eslint-plugin-eslint-comments/issues/133 thank you!

IanVS commented 3 months ago

@MichaelDeBoey if this repo is unmaintained, shouldn't it be updated / marked as unmaintained in the README and potentially archived? @mysticatea that might help avoid confusion if you're not intending to work on this plugin anymore.