search

mysticatea / npm-run-all

A CLI tool to run multiple npm-scripts in parallel or sequential.
MIT License
5.72k stars 240 forks source link

remove padend dependency #242

Closed Pomax closed 1 year ago

Pomax commented 2 years ago

This replaces the use of the string.prototype.padend dependency with the normal String.padEnd function, removing the need for 3.3Mb of dependencies.

This PR fixes https://github.com/mysticatea/npm-run-all/issues/241

Pomax commented 2 years ago

good point, bumped up the engine requirement to the oldest still-in-support version of Node (14), and updated Travis to test only the currently supported LTS versions of Node (14, 16, and 18)

leumasme commented 2 years ago

Wondered about this as well after investigating useless packages like is-bigint in my node_modules. I dont believe that this would be the correct way, however. At the very least, it would be a breaking change and require a major version bump. Perhaps just adding a tiny selfwritten padEnd implementation here is a better idea? I don't think dropping support just for the sake of not supporting out-of-date node versions is useful.

Pomax commented 2 years ago

No it wouldn't? It only changes internal code, not an external API or something. Sure, the node version got bumped, but then again, any Node version prior to 14 is fairly explicitly dead, given Node's support matrix. So if you have to, bump the major version (that's not something a PR should be doing though, that's the release maintainer's job through npm version major).

jimmywarting commented 1 year ago

👍 lgtm, would be nice to get rid of all those sub dependencies

it's fine to to a minor release as long as you bump the engines.node accordingly to the nodejs version that supports native pad. The node version in package.json will safe guard against this kind of changes and just install the version that are most suitable for the node version that you have installed.

(have a old nodejs version installed? then it will install an older release)

Really the only time that it requires a major release is when your public api changes and you can't use the same code you have already been using

zm-cttae-archive commented 1 year ago

@mysticatea tech debt PR, please review+merge if you can

Lucienest commented 1 year ago

this project seems to have abandoned

zm-cttae-archive commented 1 year ago

Hi Toru, There's a PR to slim down npm-run-all significantly over at mysticatea/npm-run-all#242https://github.com/mysticatea/npm-run-all/pull/242. Please review when you get a chance! (Again this could be 1 week, 1 month or any amount of time.)

From: Lucien Nocelli @.> Sent: 28 February 2023 13:23 To: mysticatea/npm-run-all @.> Cc: M00TSDNS @.>; Comment @.> Subject: Re: [mysticatea/npm-run-all] remove padend dependency (PR #242)

this project seems to have abandoned

— Reply to this email directly, view it on GitHubhttps://github.com/mysticatea/npm-run-all/pull/242#issuecomment-1448173995, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A5MVIFXFH5RGJHVAMPEWHUTWZX34FANCNFSM6AAAAAAQENSUVM. You are receiving this because you commented.Message ID: @.***>

Pomax commented 1 year ago

No eyes on this in over 6 months: I'm going to assume that you're not interested in PRs, @mysticatea, and I don't want to see this clog up my outstanding PR list going forward. Feel free to reopen and merge in if you're still going to have a look.

Lucienest commented 1 year ago

the owner of this repo is still active but abandoned this project, no update since 2019, pathetic @Pomax

zm-cttae-archive commented 1 year ago

please delete the last word... fwiw we can fork the package and publish this PR and all others

it would just be called npm-run-all-more

Lucienest commented 1 year ago

please delete the last word... fwiw we can fork the package and publish this PR and all others

it would just be called npm-run-all-more

what else should I say? that's the truth The project got abandoned, we can fork for sure but that doesn't change the fact.

jimmywarting commented 1 year ago

As a maintainer of other big open source projects i think it feels kind of hostile, unappreciated and unnecessary. When somebody say something negative, specially when someone puts hes heart and sole into building something free without earning anything but the communities love and respect back.

Negativity leads to developer to no longer wanting to maintain anything more for free.

By using a more neutral and factual tone, you can still convey the information without adding any negativity or judgment to it. It's important to remember that open source projects are often maintained by volunteers, and we should always show appreciation for their contributions, regardless of their level of activity or availability.

zm-cttae-archive commented 1 year ago

This was going to be a dead (really "remummified zombie") npm ticket. But someone did the 5-minute mile & made an open-source solution. Their code and review work will always remain ~90% of the total project effort even if the community forks.