search

mysticatea / regexpp

The regular expression parser for ECMAScript.
MIT License
153 stars 15 forks source link

fix: add `types` condition to the front of the `exports` #30

Open Andarist opened 1 year ago

Andarist commented 1 year ago

I added types condition to the front. package.json#exports are order-sensitive - they are always matched from the top to the bottom. When a match is found then it should be used and no further matching should occur.

Right now, the current setup works in TypeScript but it's considered a bug and it should not be relied upon, see the thread and the comment here. For that reason, I would like to fix all popular packages that misconfigured their exports this way so the bug can be fixed in TypeScript.

⚠️ note that this doesn't fix all of the types-related problems in this package (see the reported problems here). This PR only focuses on "🐛 Used fallback condition" because that's a TypeScript bug that can't be fixed before the usage gets fixed in popular packages.

MichaelDeBoey commented 1 year ago

Hi @Andarist!

Since this repo is unmaintained, you might want to re-open this PR in the @eslint-community fork https://github.com/eslint-community/regexpp

For more info about why we created this organization, you can read https://eslint.org/blog/2023/03/announcing-eslint-community-org

MichaelDeBoey commented 1 year ago

For people watching this PR: we've already started with our own fork in order to not hold the wider community back anymore: https://github.com/eslint-community/regexpp

@mysticatea We would still love to move the original repo to the new @eslint-community though.

This PR is released in @eslint-community/regexpp v4.5.1 https://github.com/eslint-community/regexpp/releases/tag/v4.5.1