search

mysticfall / pivot4j

Pivot4J provides a common API for OLAP servers which can be used to build an analytical service frontend with pivot style GUI.
Other
128 stars 101 forks source link

NON EMPTY enabled by default #154

Closed glauberalmeida closed 10 years ago

glauberalmeida commented 10 years ago

Created value setting default button NonEmpty. File: pivot4j-config.xml TAG: false Values: true or false

mysticfall commented 10 years ago

@glauberalmeida Sorry it took so long before I could write a reply. I've been away for couple of days, and we have a DNS issue on our website so I had to divert some of my time for that.

Anyway, I'm thrilled to get the first ever pull request for this project :) Thanks much for taking time to contribute, and I wish you'd continue helping the project move forward.

As to the content, I'm afraid I'll need to make a couple of modifications to what you suggested. For instance, ViewHandler is a request scoped bean, and overriding the non-empty property in its initialize() method means that a related event would be fired everytime any kind of requests are made using that backing bean, which can be problematic sometimes.

So, I'd like to sort it out based on your patch, and will try to merge it on this weekend. If you want to discuss implementation details, please drop me a line and I'll try to explain whatever is needed.

glauberalmeida commented 10 years ago

I do not know the source to question him. You already do a great job. Carry on!

[], Glauber

2014-05-16 2:44 GMT-03:00 Xavier Cho notifications@github.com:

@glauberalmeida https://github.com/glauberalmeida Sorry it took so long before I could write a reply. I've been away for couple of days, and we have a DNS issue on our website so I had to divert some of my time for that.

Anyway, I'm thrilled to get the first ever pull request for this project :) Thanks much for taking time to contribute, and I wish you'd continue helping the project move forward.

As to the content, I'm afraid I'll need to make a couple of modifications to what you suggested. For instance, ViewHandler is a request scoped bean, and overriding the non-empty property in its initialize() method means that a related event would be fired everytime any kind of requests are made using that backing bean.

So, I'd like to sort it out based on your patch, and will try to merge it on this weekend. If you want to discuss implementation details, please drop me a line and I'll try to explain whatever is needed.

— Reply to this email directly or view it on GitHubhttps://github.com/mysticfall/pivot4j/pull/154#issuecomment-43299210 .

mysticfall commented 10 years ago

Made various changes before the merge including the preference key name. So, please refer pivot4j-config.xml and make appropriate changes to your configuration file before testing.

mysticfall commented 10 years ago

@glauberalmeida I changed my mind on how to implement this feature with my last commit.

Accordingly, the correct settings would be as below : 

    <model>
        <nonEmpty default="false" />
    </model>

Sorry for the confusion!

glauberalmeida commented 10 years ago

No problem. Thank you!

2014-05-18 10:17 GMT-03:00 Xavier Cho notifications@github.com:

@glauberalmeida https://github.com/glauberalmeida I changed my mind on how to implement this feature with my last commit.

Accordingly, the correct settings would be as below :

<model>
    <nonEmpty default="false" />
</model>

Sorry for the confusion!

— Reply to this email directly or view it on GitHubhttps://github.com/mysticfall/pivot4j/pull/154#issuecomment-43439512 .

mysticfall commented 10 years ago

@glauberalmeida Urg... just found out I broke the report opening function with the last commit. I didn't realized that till now becuase I use a different config file for testing.

I just released 0.9 version and 1.0-SNAPSHOT builds are available as well. Please download load one of those and check if the issue is really resolved.

Sorry for the confusion!