search

mysticfall / pivot4j

Pivot4J provides a common API for OLAP servers which can be used to build an analytical service frontend with pivot style GUI.
Other
128 stars 101 forks source link

fixed: #186 Headers rendered incorrectly with showParentMembers and parent-child hierachy #187

Closed d-amelin closed 9 years ago

d-amelin commented 9 years ago

the fix of issue Headers rendered incorrectly with showParentMembers and parent-child hierachy #186

mysticfall commented 9 years ago

If I understood correctly, we need to compare both level and depth of those members, otherwise it would break some test cases, like ComplexAggregationIT.testAggregation().

I've slightly modified the source code to reflect the change, and also removed the comment because it contains a reference to an external issue, and I thought it would be sufficient if we just put a link to this PR in the commit message, instead of including the description in the source itself.

Please feel free to share your opinions about this, and thanks much for the contribution!

d-amelin commented 8 years ago

You're right. we need to compare both level and depth. Sorry for comment with reference to an external issue. Yes, it is sufficient just put a link to this PR in the commit message Thank you