search

mysticfall / pivot4j

Pivot4J provides a common API for OLAP servers which can be used to build an analytical service frontend with pivot style GUI.
Other
128 stars 101 forks source link

Added option to include 'All member' when place hierarchy #205

Closed ohierro closed 7 years ago

ohierro commented 7 years ago

I'm currently working with mondrian dsp capacities to filter output results based on security criterias.

In this case, I've found the necessity to, when I add a Hierarchy and I want to include all children, prevent include 'All' field', because security filtering does that the result displayed is wrong.

I modified PlaceHierarchyTransform to allow to specify a flag to control this.

mysticfall commented 7 years ago

@ohierro I'm sorry it took so long. It looks good to me, except for extra space characters which doesn't match the coding conventions followed by other parts of the codebase.

Could you reformat the changed source file (using Eclipse's default code formatter would suffice) and modify your commit?

Thanks!

ohierro commented 7 years ago

Hi,

I've used Eclipse code formatter in IntelliJ to reformat code, but I'm not sure if it done it correctly.

Could you tell me what's incorrectly formatted? To try to adjust the formatter manually, because I don't see to much changes in my last commit :)

Thanx!

mysticfall commented 7 years ago

Oh, please don't worry. It seems that the code formatting was inconsistent anyway, so I just reapplied the code formatter to the modified sources.

I'll close this PR, as I manually merged your commits (with proper author information) already. I'll publish a new update to the repository soon.

Thanks much for the contribution :)