Correcting problems reported on Issue #212

mysticfall / pivot4j

Pivot4J provides a common API for OLAP servers which can be used to build an analytical service frontend with pivot style GUI.

Other

128 stars 101 forks source link

Correcting problems reported on Issue #212 #214

Open vgartner opened 7 years ago

vgartner commented 7 years ago

Addresses and corrects problems reported on Issue #212

mysticfall commented 7 years ago

I've made a few comments about your suggestions, so I'd like you to review them and let me know how you think.

Thanks much for the contribution! :smiley:

vgartner commented 6 years ago

Hi, you're welcome. Maybe this can sound stupid, but... where can I find the comments? I haven't find them.... (^_^) Best regards.

mysticfall commented 6 years ago

@vgartner I might be doing something stupid myself, since it's the first time I've used the new review feature :sweat_smile:

Anyway, aren't my comments visible above? On my end, I can see them along with the relevant lines from your code. If you can't, maybe you can try switching to Files Changed tab and see if you can read them there.

vgartner commented 6 years ago

Hi @mysticfall nope, can't find it yet... :grin: I've attached some screenshots to show to you what I see... :thumbsup: Regards.

conversation files files1 pull_request

mysticfall commented 6 years ago

@vgartner Oh, my.... I feel stupid! :sweat: I just realized that I need to actually 'submit' the review after I write individual comments.

I believe now you should be able to see it. Sorry for the confusion!