mystor / meteor-routecore

Client and server side rendering/routing powered by React
84 stars 6 forks source link

reactive: false not working #24

Open necrodome opened 9 years ago

necrodome commented 9 years ago

I ma trying to disable reactive future on a component, but it seems to be not working. Is that a limitation of the react integration or am I doing something wrong?

For example, on https://github.com/mystor/todomvc/blob/routecore/labs/architecture-examples/meteor-routecore/app.jsx#L227, adding reactive: false seems to be doing nothing.

mystor commented 9 years ago

I don't see any reason why it wouldn't work. Routecore doesn't touch the reactive system used to refresh queries from meteor at all. On Apr 2, 2015 8:16 PM, "Selem Delul" notifications@github.com wrote:

I ma trying to disable reactive future on a component, but it seems to be not working. Is that a limitation of the react integration or am I doing something wrong?

For example, on https://github.com/mystor/todomvc/blob/routecore/labs/architecture-examples/meteor-routecore/app.jsx#L227, adding reactive: false seems to be doing nothing.

— Reply to this email directly or view it on GitHub https://github.com/mystor/meteor-routecore/issues/24.

necrodome commented 9 years ago

Routecore doesn't touch the reactive system

I see, that's what I thought. Any chance to check that behaviour on the demo app? No matter what I tried, it keeps updating the view.

I tried:

mystor commented 9 years ago

The entire render code is rerun within a reactive computation. If anything would cause the component to update, the entire code reruns. Make sure that one of the other reactive queries isn't being run. On Apr 2, 2015 9:27 PM, "Selem Delul" notifications@github.com wrote:

Routecore doesn't touch the reactive system

I see, that's what I thought. Any chance to check that behaviour on the demo app? No matter what I tried, it keeps updating the view.

I tried:

  • adding reactive: false
  • using fetch()

— Reply to this email directly or view it on GitHub https://github.com/mystor/meteor-routecore/issues/24#issuecomment-89107436 .