search

mystor / meteor-routecore

Client and server side rendering/routing powered by React
84 stars 6 forks source link

Update React to 0.13.1 #27

Closed jantimon closed 9 years ago

jantimon commented 9 years ago

I updated the react library and patched the client and server to match the react api changes.

As the react-addons npm package is deprecated the react-with-addons.js file was build using browserify: 

browserify --standalone React .npm/package/node_modules/react/addons.js > react-with-addons-0.13.1.js

It seems to work well in my project but I recommend further testing

mystor commented 9 years ago

Thanks for the PR. I'll try to find some time in the next couple of days to test out the changes, and I'll merge it when we get there.

mystor commented 9 years ago

I still don't have enough time to test it myself, can you confirm that the BlazeComponent still works correctly, and that reactive updates through meteor correctly trigger react re-renders?

jantimon commented 9 years ago

I haven't tested the BlazeComponents - However the (re)rendering works well

Anonyfox commented 9 years ago

I just used the loginButtons as BlazeComponent - works fine so far. (https://atmospherejs.com/ian/accounts-ui-bootstrap-3)

mystor commented 9 years ago

I'm so sorry that I've been so busy, and unable to check up on this.

I imagine it probably is good, and will merge & publish it. Thank you so much @jantimon for the patch.

mystor commented 9 years ago

This has been merged & published. Hopefully there are no serious problems :)

jantimon commented 9 years ago

Cool :+1: