mystor / phlay

Phlay your commits onto Phabricator
19 stars 17 forks source link

Doesn't set file modes for new files #46

Closed glandium closed 5 years ago

glandium commented 5 years ago

I thought I've had that work in the past, but for some reason, it didn't happen for https://phabricator.services.mozilla.com/D16302 where taskcluster/scripts/misc/build-minidump-stackwalk.sh is missing the executable bit, that is properly set locally (otherwise, my try pushes would have blatantly failed).

mystor commented 5 years ago

Huh, that's super weird. I definitely see 100644 mode on the raw diff, which is wrong. Phlay should be preserving this information, though, the code for doing that definitely at least seems to still be there.

glandium commented 5 years ago

Happened again in https://phabricator.services.mozilla.com/D24322