mystor / phlay

Phlay your commits onto Phabricator
19 stars 17 forks source link

Fix version number comparison #59

Closed Rob--W closed 5 years ago

Rob--W commented 5 years ago

"0.1.10" > "0.1.9" is False, which results in phlay being eternally stuck at an older version (and experience #58). Fix this by using a version comparator instead of a string comparison.

I used a version comparator, but an alternative approach would be to use an equality operator. That wouldn't put restrictions on the format of the version number. Let me know what you prefer.

To make sure that users don't get stuck on 0.1.9 or earlier, the package version should be bumped to 0.2.0.

mystor commented 5 years ago

Awesome, thanks