mysurvive / pf2e-thaum-vuln

Improvement for Thaumaturge Exploit Vulnerability
MIT License
10 stars 12 forks source link

Use implement helper #100

Closed xyzzy42 closed 6 months ago

xyzzy42 commented 6 months ago

Fixes a bug in socket.js that affects Amulet.

Use getImplement for tome, amulet

Somewhat shorter.  Also, should be easier to change things with the
flags without having to edit as much code afterward.

This also removes the check for having the Thaumaturge class from the
Tome dialog.  It's faster to check for the implement flags than to check
for the class, and a non-thaum wouldn't have the implement flags.

And if the actor isn't a thaum, but has the flags, then they must be
some kind of archetype or homebrew thing that gets a thaum implement's
abilities.  And so giving the implement benefits would be the correct
thing to do.