mysurvive / pf2e-thaum-vuln

Improvement for Thaumaturge Exploit Vulnerability
MIT License
10 stars 11 forks source link

Use preCreateChatMessage rather than createChatMessage #112

Closed xyzzy42 closed 5 months ago

xyzzy42 commented 5 months ago

The former is only called once, for the client who creates the message, before it's acutally done, and has the option to disable creating the message by returning flase.

The latter is also called once when the message is made, after it's done, can't prevent it from getting created, and for every client. I didn't notice that last difference, and the rest seem like a better choice.