mysurvive / pf2e-thaum-vuln

Improvement for Thaumaturge Exploit Vulnerability
MIT License
10 stars 13 forks source link

Rework flags and manage implements #168

Closed xyzzy42 closed 2 months ago

xyzzy42 commented 3 months ago

Big rework of manage implements and the selectedImplements flags. It's half the size of the existing code. The individual commits do smaller pieces and have detailed descriptions.

Main features:

xyzzy42 commented 2 months ago

Turns out setFlag() didn't work the way I thought it did. It doesn't set a flag to the object supplied, but rather merges the object into the existing flag. Removing an implement flag not on the character sheet anymore needs an explicit "-=impSlug": true in the flags object. Fixed this in latest push.

mysurvive commented 2 months ago

Thanks for doing this. It's something I wanted to get around to eventually but haven't had the chance to.