mysurvive / pf2e-thaum-vuln

Improvement for Thaumaturge Exploit Vulnerability
MIT License
10 stars 13 forks source link

Exploit Vulnerability as an action #181

Open xyzzy42 opened 1 week ago

xyzzy42 commented 1 week ago

This is my attempt to get the EV roll to follow all the system automation stuff, by using the SingleCheckAction class from the system used by a bunch of other actions.

Everything appears to work. The trick is to use an EphemeralEffect to the give the target of the EV check an effect that uses a SpecialStatistic to give the target an EV DC to roll against.

There is one issue, the action code doesn't know how to make a translated check-DC label for lore skills. There's already a " Check" translation format it could use, but the bit of code doing the flavor text doesn't do that. I've got a PR for the system that fixes this, https://github.com/foundryvtt/pf2e/pull/17223