search

mysurvive / pf2e-thaum-vuln

Improvement for Thaumaturge Exploit Vulnerability
MIT License
10 stars 12 forks source link

Bug - Personal Antithesis Weakness Not Being Removed After Turn #28

Closed JasonMColton closed 1 year ago

JasonMColton commented 1 year ago

Start Encounter with 2 allies and 1 enemy.

Level 3 Thaumaturge holding slashing weapon uses Exploit Vulnerability, Applies Personal Antithesis, Strikes; Weakness 3 Slashing is applied. Damage dealt is what the Thaumaturge rolled +3

End Turn

Enemy still has Weakness 3 Slashing

Level 3 Fighter holding a slashing weapon attacks. Deals damage rolled +3

Foundry v10 Build 291 Pathfinder 2e 4.12.1

Module Management

Advanced Macros 1.19.6 libwrapper 1.12.12.0 PF2e Exploit Vulnerability 0.10.0 socketlib 1.0.12 The Forge 1.10

HugoSimoes55 commented 1 year ago

This issue is still occurring with me.

Foundry v11.313 Pathfinder 5.6.2

PF2e Exploit Vulnerability 0.12.1 libwrapper 1.12.13.0 socketlib 1.0.13

Tried with and without Advanced Macros and it still happens.

I don't use The Forge,

When I end the turn, it doesn't show any errors in the console.

mysurvive commented 1 year ago

This issue is still occurring with me.

Foundry v11.313 Pathfinder 5.6.2

PF2e Exploit Vulnerability 0.12.1 libwrapper 1.12.13.0 socketlib 1.0.13

Tried with and without Advanced Macros and it still happens.

I don't use The Forge,

When I end the turn, it doesn't show any errors in the console.

Any errors in the console? I just used it last night and this didn't happen for me. Also, this issue is from May, this has been happening to you for 5 months?

mysurvive commented 1 year ago

image image Yeah, just checked, I'm not seeing this.

  1. Check the console (f12) for errors
  2. Make sure you're striking each turn, not just applying damage (the current iteration requires an attack roll or saving throw to update the weakness value)
  3. Send reproduction steps.
  4. Are you the GM? 4a. If you are not the GM, is the GM logged in?
HugoSimoes55 commented 1 year ago

I have only recently added this module due to playing in a mini-adventure as a thaumaturge.

1 - no errors on console regarding thaumaturge (only some regarding sound files) 2 - possible explanation below 3 - Start encounter with 2 friendlies and 3 bandits. Exploit Vuln - Personal Antithesis (Applied to all because of sympathetic vuln) -> Attack and deal damage with weakness -> End turn -> Weakness still there (i was under the idea that the weakness would be removed sooner than on another attack roll. Am i wrong?) 4 - all this as a DM

Possible Explanation - When you said that attack rolls are required, does that include targeting? Because if so, that might've been what happened. Another player might've attacked without targeting which didn't remove the weakness (though i could've sworn it happened when i used a targeted attack roll but now i can't replicate it).

HugoSimoes55 commented 1 year ago

Or maybe i can't replicate it now because i added Advanced Macros. Don't know how necessary it is.

mysurvive commented 1 year ago

Targeting is required to update the weakness value. This will go away in the next pf2e system release The weakness value is only updated on an attack roll, this was a limitation, but the next pf2e system release fixes that - I already have a working build, I just need to wait for the release to drop. Advanced macros doesn't do anything with this module Glad it's working now.