search

mythicalprogrammer / fumigate

0 stars 0 forks source link

fix these warnings #229

Closed mythicalprogrammer closed 4 years ago

mythicalprogrammer commented 4 years ago

warning: variable "perfume" is unused (if the variable is not meant to be used, prefix it with an undersc ore) lib/fumigate_web/controllers/user/perfume_controller.ex:31

warning: invalid association perfume_approvals in schema Fumigate.Fragrance.Accord: associated schema F umigate.Fragrance.PerfumeApproval does not exist lib/fumigate/fragrance/accord.ex:1: Fumigate.Fragrance.Accord (module)

warning: invalid association companies in schema Fumigate.Approval.PerfumeApproval: :join_through schem a Fumigate.Fragrance.PerfumeApprovalCompanyJoin does not exist lib/fumigate/approval/perfume_approval.ex:1: Fumigate.Approval.PerfumeApproval (module)

warning: invalid association notes in schema Fumigate.Approval.PerfumeApproval: :join_through schema Fu migate.Fragrance.PerfumeApprovalNoteJoin does not exist lib/fumigate/approval/perfume_approval.ex:1: Fumigate.Approval.PerfumeApproval (module)

warning: invalid association accords in schema Fumigate.Approval.PerfumeApproval: :join_through schema Fumigate.Fragrance.PerfumeApprovalAccordJoin does not exist lib/fumigate/approval/perfume_approval.ex:1: Fumigate.Approval.PerfumeApproval (module)

mythicalprogrammer commented 4 years ago

To see the warning again:

mix compile --force

https://stackoverflow.com/questions/52360555/how-do-you-get-the-elixir-compiler-to-show-warnings-when-running-a-phoenix-serve

mythicalprogrammer commented 4 years ago

first warning investigation:

warning: variable "perfume" is unused (if the variable is not meant to be used, prefix it with an underscore) lib/fumigate_web/controllers/user/perfume_controller.ex:31

Fixed. 4 more warnings

mythicalprogrammer commented 4 years ago

second warning investigation:


> warning: invalid association `perfume_approvals` in schema Fumigate.Fragrance.Accord: associated schema Fumigate.Fr
> agrance.PerfumeApproval does not exist
>   lib/fumigate/fragrance/accord.ex:1: Fumigate.Fragrance.Accord (module)
mythicalprogrammer commented 4 years ago

The problem is:

associated schema Fumigate.Fragrance.PerfumeApproval does not exist

It should be Fumigate.Approval.PerfumeApproval

mythicalprogrammer commented 4 years ago

The offending line in accord.ex

13 many_to_many :perfume_approvals, Fumigate.Fragrance.PerfumeApproval, 14 join_through: Fumigate.Fragrance.PerfumeApprovalAccordJoin

mythicalprogrammer commented 4 years ago

Third warning investigation:

warning: invalid association companies in schema Fumigate.Approval.PerfumeApproval: :join_through schema Fumigate .Fragrance.PerfumeApprovalCompanyJoin does not exist lib/fumigate/approval/perfume_approval.ex:1: Fumigate.Approval.PerfumeApproval (module)

fixed

mythicalprogrammer commented 4 years ago

4th investigation:

warning: invalid association notes in schema Fumigate.Approval.PerfumeApproval: :join_through schema Fumigate.Fra grance.PerfumeApprovalNoteJoin does not exist lib/fumigate/approval/perfume_approval.ex:1: Fumigate.Approval.PerfumeApproval (module)

fixed

mythicalprogrammer commented 4 years ago

5th investigation:

warning: invalid association accords in schema Fumigate.Approval.PerfumeApproval: :join_through schema Fumigate.Fragrance.PerfumeApprovalAccordJoin does not exist lib/fumigate/approval/perfume_approval.ex:1: Fumigate.Approval.PerfumeApproval (module)

mythicalprogrammer commented 4 years ago

Fixed all warnings.