search

mythmon / edwin

A bug management system
Mozilla Public License 2.0
4 stars 0 forks source link

Update most imports to pull from index.js modules. #71

Closed mythmon closed 9 years ago

mythmon commented 9 years ago

A few didn't work with the new patter. Added comments to these. Maybe problems with circular imports or import order?

@willkg if you have any insights about the few that can't use this pattern, I'm really puzzled.

NB: Circular imports can work fine in ES6, with some caveats. In this way it is different from Python.

willkg commented 9 years ago

Is it correct to say that importing BaseStore with the new pattern never works?

mythmon commented 9 years ago

I'd be comfortable saying that. I have never seen it work. Though I don't know why.

mythmon commented 9 years ago

@willkg Any thing you'd like to see different about this PR? Otherwise I think we should merge it.

willkg commented 9 years ago

I haven't had time to really read about how imports and ES6 work and all that and I'm not sure I'm going to have time tomorrow. I don't think this should block on me.

Possibilities: Ask someone else who would know more? pomax? jlongster? r1cky? someone else with react/flux/ES6 knowledge?