myuhe / org-gcal.el

Org sync with Google Calendar
450 stars 113 forks source link

[WIP] Add multiple accounts support #72

Open ayyess opened 7 years ago

ayyess commented 7 years ago

A solution to issue #71 where calendars on different google accounts can't be synced at the same time because they have different access tokens.

org-gcal-token-plist has been renamed to org-gcal-tokens-plist and contains each calendars plist. The calendar's url is used as the key. Each calendars plist is also saved in separate files i.e.(concat org-gcal-token-file calendar-url) All the (plist-get org-gcal-tokens-plist calendar-url) calls can be cleaned up.

j-martin commented 7 years ago

Confirming this PR works great with multiple accounts on different domains / GSuite accounts.

@andjscott do you think it should be ok to remove the [WIP] tag/tilte?

ayyess commented 7 years ago

I'm glad it works for you. I originally put the WIP in the title because emacs seemed to repeatedly write to the files holding the token for each account and didn't find the cause. I can't remove the WIP from the title but won't mind if a repo admin can and wants to change it.

blarghmatey commented 7 years ago

I manually applied this patch and resolved the conflicts and can confirm that it is working wonderfully for me as well. It would be awesome if we can get the merged into the project. @andyjscott would it be possible for you to resolve the merge conflict so that @myuhe can more easily accept this patch?

Thanks to everyone for this project!

ayyess commented 7 years ago

I've merged the master branch into this branch but haven't tested the *-at-point functions or looked at this code for a while so let me know how you get on.

blarghmatey commented 7 years ago

Thanks!

bobberb commented 6 years ago

@andyjscott are -at-point function still not working in your branch ?

bqv commented 5 years ago

@myuhe reminder that this exists and should be merged

bobberb commented 5 years ago

@bqv

The community left this repo for

https://github.com/kidd/org-gcal.el/

And that repo is what MELPA currently references

telotortium commented 4 years ago

Hi everyone! This repository is obsolete - the actively developed fork is now https://github.com/kidd/org-gcal.el, which is also the "org-gcal.el" on MELPA (see #115). I'm one of the maintainers of https://github.com/kidd/org-gcal.el. I can't directly close issues or PRs on this repo, but please download https://github.com/kidd/org-gcal.el and see if your issue or PR is still applicable. If so, open an issue or PR on https://github.com/kidd/org-gcal.el. In any case, you should close your issue or PR in this repo.