Remove an unnecessary jar in xgboost

myui / hivemall

Scalable machine learning library for Apache Hive/Spark/Pig

http://hivemall.incubator.apache.org/

504 stars 153 forks source link

Remove an unnecessary jar in xgboost #341

Closed maropu closed 8 years ago

maropu commented 8 years ago

This pr is to remove hivemall-xgboost-0.4.2-rc.2.jar because it does not include xgboost native binaries.

coveralls commented 8 years ago

Coverage increased (+0.3%) to 35.138% when pulling fa12093a5b843a7acba105eb4cff7724426846c8 on maropu:RemoveUnneededXgboostJar into df4f4ddf0516bdf89c084884ef45d6df2c1edae0 on myui:master.

coveralls commented 8 years ago

Coverage remained the same at 34.86% when pulling fa12093a5b843a7acba105eb4cff7724426846c8 on maropu:RemoveUnneededXgboostJar into df4f4ddf0516bdf89c084884ef45d6df2c1edae0 on myui:master.

oza commented 8 years ago

Related issue? I failed to compile hivemall on trunk, after removing ~/.m2 directory

[ERROR] Failed to execute goal on project hivemall-xgboost: Could not resolve dependencies for project io.github.myui:hivemall-xgboost:jar:0.4.2-rc.2: Could not find artifact ml.dmlc:xgboost4j:jar:0.10 in cloudera (https://repository.cloudera.com/artifactory/cloudera-repos/) -> [Help 1]
[ERROR]

If it's related, it's reasonable to fix here

myui commented 8 years ago

merged. Thanks @maropu

maropu commented 8 years ago

@oza This pr is not directly related to the issue though, yea it is one of issues in the xgboost module. We have to install xgboost4j in advance because the package does not exist in the maven central; to solve the issue, you need to say mvn validate && mvn package. This is a just work-around, so I think we'd better to upload the package into the maven central until an upcomming release.