myui / hivemall

Scalable machine learning library for Apache Hive/Spark/Pig
http://hivemall.incubator.apache.org/
504 stars 153 forks source link

Inject the Hivemall aggregate functionality in RelationalGroupedDataset #368

Closed maropu closed 8 years ago

maropu commented 8 years ago

This pr is to remove weird groupby clauses in the spark module. In the current version, voted_avg() is used like;

df.select(...).groupby.voted_avg()

This pr changes this in a Spark way.

df.select(...).groupBy.voted_avg()
coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.005%) to 34.559% when pulling 82adf34c50c1fe1ba670ad81e417a8107c6a2c96 on maropu:BrushupHivemallAggregate into 9f9dbd2a0fb70b58b99aa7f438c4c151059fb93b on myui:master.

myui commented 8 years ago

LGTM. Merged. Thanks.