search

myusuf3 / delorean

Delorean: Time Travel Made Easy
http://delorean.rtfd.org/
MIT License
1.84k stars 128 forks source link

Added replace method on Delorean object #81

Closed masnun closed 8 years ago

masnun commented 8 years ago

As discussed in #80 - please review and let me know if there needs to be further modifications.

myusuf3 commented 8 years ago

docs? :)

masnun commented 8 years ago

Ah yes, sorry forgot. Let me get to that.

On Sat, Mar 12, 2016 at 2:22 AM, Mahdi Yusuf notifications@github.com wrote:

docs? :)

— Reply to this email directly or view it on GitHub https://github.com/myusuf3/delorean/pull/81#issuecomment-195532143.

Abu Ashraf Masnun | +8801711960803 | http://masnun.me

masnun commented 8 years ago

I added the docs. Please review.

masnun commented 8 years ago

I added a test showing that the timezone doesn't change. And a test using datetime arithmetic with timedelta.

masnun commented 8 years ago

And a few asserts on the datetime objects.

masnun commented 8 years ago

Is there anything else you would like me to help with?

myusuf3 commented 8 years ago

I just need a moment to look it over. I will try to get to it before this weekend.

masnun commented 8 years ago

Hi, just checking how it looks. Did you manage to get a look at it?

myusuf3 commented 8 years ago

Awesome thanks for contribution. Sorry for my terrible delay.

masnun commented 8 years ago

No problem :-)

On Friday, September 16, 2016, Mahdi Yusuf notifications@github.com wrote:

Awesome thanks for contribution. Sorry for my terrible delay.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/myusuf3/delorean/pull/81#issuecomment-247654357, or mute the thread https://github.com/notifications/unsubscribe-auth/AALsN-wSRKxcldTXL96DDQIdpBap_xOoks5qqsyagaJpZM4Hu7w_ .

Abu Ashraf Masnun | +8801711960803 | http://masnun.me