search

myvoice-nigeria / myvoice

MyVoice Nigeria
https://myvoicenigeria.com
BSD 2-Clause "Simplified" License
3 stars 1 forks source link

Serial numbers with 0 as first digit prompt invalid message to registrars #105

Closed laurenweinstein closed 10 years ago

boyombo commented 10 years ago

Hi Lauren, I have tried to reproduce this but haven't been able to. Are you sure the error message isn't because the serial number is less than 3 digits ?

laurenweinstein commented 10 years ago

Sorry, we noticed this trend first, but there might be a different cause. I'm sorry about that. I've seen a bunch that get the invalid message when everything looks right, serial between 3-6 digits.

For example, 10:20am entry here: https://textit.in/contact/read/118151/

On Tue, Jul 8, 2014 at 9:40 PM, Bayo Opadeyi notifications@github.com wrote:

Hi Lauren, I have tried to reproduce this but haven't been able to. Are you sure the error message isn't because the serial number is less than 3 digits ?

— Reply to this email directly or view it on GitHub https://github.com/caktus/myvoice/issues/105#issuecomment-48396640.

Lauren Weinstein DESIGN ASSOCIATE 45 E. 20th St, 5th Floor | New York, NY 10003 office: +1 212 388 1010 | mobile: +1 973 271 2397 nigeria mobile | +234 814 223 5832 lauren@reboot.org www.reboot.org

boyombo commented 10 years ago

I believe it may be leading/trailing whitespace which we had not made provision for (that's why the generic error message). We have a fix for that now.

On Tue, Jul 8, 2014 at 9:47 PM, laurenweinstein notifications@github.com wrote:

Sorry, we noticed this trend first, but there might be a different cause. I'm sorry about that. I've seen a bunch that get the invalid message when everything looks right, serial between 3-6 digits.

For example, 10:20am entry here: https://textit.in/contact/read/118151/

On Tue, Jul 8, 2014 at 9:40 PM, Bayo Opadeyi notifications@github.com wrote:

Hi Lauren, I have tried to reproduce this but haven't been able to. Are you sure the error message isn't because the serial number is less than 3 digits ?

Reply to this email directly or view it on GitHub https://github.com/caktus/myvoice/issues/105#issuecomment-48396640.

Lauren Weinstein DESIGN ASSOCIATE 45 E. 20th St, 5th Floor | New York, NY 10003 office: +1 212 388 1010 | mobile: +1 973 271 2397 nigeria mobile | +234 814 223 5832 lauren@reboot.org www.reboot.org

Reply to this email directly or view it on GitHub https://github.com/caktus/myvoice/issues/105#issuecomment-48397449.

@boyombo http://bayo.opadeyi.net A designer knows he has achieved perfection not when there is nothing left to add, but when there is nothing left to take away. --Antoine de Saint-Exupery

priyankaincode commented 10 years ago

So we took a look in Django, and it seems that serial numbers that begin with 0 are simply having the 0 removed before displaying in the Django dashboard. @boyombo could that be fixed so that the 0 still displays?

boyombo commented 10 years ago

The serial us stored as a number that's why it strips away the leading '0'. I'll change it to a string. On Jul 9, 2014 12:29 PM, "Priyanka" notifications@github.com wrote:

So we took a look in Django, and it seems that serial numbers that begin with 0 are simply having the 0 removed before displaying in the Django dashboard. @boyombo https://github.com/boyombo could that be fixed so that the 0 still displays?

Reply to this email directly or view it on GitHub https://github.com/caktus/myvoice/issues/105#issuecomment-48458292.

priyankaincode commented 10 years ago

Ah. Great, thanks!