PyV8 Build Script subprocess call.

[GoogleCodeExporter]

Setup.py:

proc = subprocess.Popen(["scons", "arch="+arch], cwd=V8_HOME, shell=True, 
stdout=sys.stdout, stderr=sys.stderr)

With shell=True in the subprocess call, I was seeing that scons was not taking 
the arch command.   It looks like it gets passed to the shell instead.  It 
think it should be:

proc = subprocess.Popen(["scons", "arch="+arch], cwd=V8_HOME, shell=False, 
stdout=sys.stdout, stderr=sys.stderr)

OR

proc = subprocess.Popen("scons arch="+arch, cwd=V8_HOME, shell=True, 
stdout=sys.stdout, stderr=sys.stderr)

If someone else could verify that would be great.

Original issue reported on code.google.com by ATM1...@gmail.com on 8 Feb 2011 at 4:48

[GoogleCodeExporter]

Original comment by flier...@gmail.com on 9 Feb 2011 at 7:54

• Changed state: Accepted
• Added labels: OpSys-All

[GoogleCodeExporter]

I test it on a Fedora 14 x64 system with GCC 4.5.1 and Python 2.7.

Please verify the issue with pyv8 code after SVN trunk r331, thanks.

Original comment by flier...@gmail.com on 13 Feb 2011 at 8:51

• Changed state: Fixed
• Added labels: OpSys-Linux
• Removed labels: OpSys-All