Automatic Add new install not working

EliteDev2 commented 6 months ago

Steps to reproduce/复现步骤

Open lsposed manager and select any module
Click on 3 dots on top right -> select -> check automatic add

Expected behaviour/预期行为

The Automatic add option should remain checked and should automatically add any new app installed in that module scope.

Actual behaviour/实际行为

The automatic add option gets un-checked and no new app installation is added to module scope

Xposed Module List/Xposed 模块列表

Android faker
Bootloader spoofer

Magisk Module List/Magisk 模块列表

Magiskhide prop
Sensitive props v3
Shamiko
Universal safetynet fix Displayx
Lsposed mod 1.9.2

LSPosed version/LSPosed 版本

1.9.2 mod (7174)

Android version/Android 版本

11

Magisk version/Magisk 版本

26.4

Riru version/Riru 版本

N/A

Version requirement/版本要求

[X] I am using latest debug CI version of LSPosed and enable verbose log/我正在使用最新 CI 调试版本且启用详细日志

Logs/日志

LSPosed_2024-01-03T02_46_04.215.zip

mywalkb commented 6 months ago

Could you test this action when the build end?

0x1337F00D commented 6 months ago

~Not the author, but I tested that build and it still has the same problem sadly~

EDIT: Works after clean reinstall, thank you :)

mywalkb commented 6 months ago

The clean reinstall would have solved it even earlier. The missing column in the database is caused by a transition from LSPosed to LSPosed_mod, where the update is not done because there is the presumption that it is already there, now with this patch it should always update.

eku commented 5 months ago

... now with this patch it should always update.

LSPosed 1.9.2 (7220) - unfortunately not.

mywalkb commented 5 months ago

... now with this patch it should always update.

LSPosed 1.9.2 (7220) - unfortunately not.

send me log, so I can see if your issue is the same

eku commented 5 months ago

send me log, so I can see if your issue is the same

Of course, here you go.

LSPosed_2024-02-04T14_36_49.185018.zip

mywalkb commented 5 months ago

Of course, here you go.

Could you test this action?

eku commented 5 months ago

Could you test this action?

Bug not fixed with build 7221. Please find attached the logs.

LSPosed_2024-02-05T17_34_12.943829.zip

mywalkb commented 5 months ago

Bug not fixed with build 7221. Please find attached the logs.

I don't know how but your database got to the latest version without having executed the statement that adds the automatic_add column, there are 2 possible ways:

uninstall LSPosed_mod and reinstall it, so the database is recreated from scratch
modify the database /data/adb/lspd/config/modules_config.db by executing this SQL statement: ALTER TABLE modules ADD COLUMN automatic_add BOOLEAN DEFAULT 0 CHECK (automatic_add IN (0, 1)); for this last operation there are various possibilities to use a command line sqlite3 client usually installed on custom ROMs but not on stock ROMs, or to use a SQLite Database Editor with root access

eku commented 4 months ago

I don't know how but your database got to the latest version without having executed the statement that adds the automatic_add column

So the version of the DB schema was increased without migrating it. Software error? Is the source code covered by tests?

uninstall LSPosed_mod and reinstall it, so the database is recreated from scratch

That's what I did in the end.

mywalkb commented 4 months ago

Software error? Is the source code covered by tests?

Under normal conditions the update works, there is no software error, otherwise there wouldn't be all these people downloading and the source code is covered by tests. In this case, not being able to recreate the issue, I made some hypotheses. The issue only arises when you go from the original LSPosed to the mod version, if you start directly with the mod version the issue doesn't exist. In the end it is a column to add to a table there is nothing complicated. I don't gain anything if you use my version or not, I don't care about fame, if it's useful to you good, otherwise it's fine too.

mywalkb / LSPosed_mod