search

mywave82 / opencubicplayer

Open Cubic Player (unix fork). Music visualizer for various tracked music formats (amiga modules, S3M, IT), chiptunes and other formats related to demoscene
https://stian.cubic.org/project-ocp.php
GNU General Public License v2.0
280 stars 19 forks source link

unifont path for ubuntu #106

Closed bkw777 closed 1 year ago

bkw777 commented 1 year ago

ubuntu:

$ sudo apt install fonts-unifont
$ ./configure --with-unifontdir-otf=/usr/share/fonts/opentype/unifont`
mywave82 commented 1 year ago

What exactly is the problem you are trying to describe? The default path uses --datarootdir, which against defaults to using --prefix, so if you do not specify --prefix and/or --datarootdir, the default path will be /usr/local/share/fonts/opentype/unifont

The is the expected autoconf default behaviour.

bkw777 commented 1 year ago

Since there are some default paths that are searched, that implies there is some intended effort to have the common case work out of the box. So I was just supplying the finding that this is the out of the box path on ubuntu.

Now that you say it's because of $PREFIX, I don't recall many other times where the destination prefix is more than the first default try for sources and dependencies, not the only try.

I haven't looked yet but I can't imagine that this is just the way autoconf works, since I feel like I must have noticed that sometime in the last 30 years. But you never know.

Would you mind a pr that adds searching /usr after searching prefix if they aren't the same?

mywave82 commented 1 year ago

I'm always open for PRs

bkw777 commented 1 year ago

I'm about to give up on figuring out how autotools expects one to handle a case like this "properly".

We want to be able to install to /usr/local, and then at run-time load something from /usr, and that thing does not happen to be an executable or a library, and so there is no provision for that, that I can see, other than what you're already doing which is supply a --with option.

I don't want to offer anything too hacky and there is a method to provide the path so that the program works fine at run-time, and this isn't exactly a critical piece of infrastructure utility software, so... guess I will shut up now! Maybe I'll submit a pr some time but might as well close this issue since I also might never and it's not really much of a problem anyway.

mywave82 commented 1 year ago

https://github.com/mywave82/opencubicplayer/commit/96286b7d75ded92da325d8aad823e1e39cf6cb60

Makes it easier to see what is going on atleast.