Closed sundbry closed 9 months ago
I was able to hack the code up enough to verify that the address parameter is not nil. It looks to me like the problem is the ParseURL function returns a reference to a URL from the stack rather than a value here, but I am not ordinarily a go programmer so I'm not entirely sure if that's valid or not.
Great catch @sundbry! I am not even sure how I had this working initially (it's been running in production since May)--I am guessing it's because I am only using the JSON config for my Caddy deployments, so I never caught this specific error when using Caddyfile
.
I have 2 MR's listed below that I think fix the problem and do a bunch of cleanup that was overdue. I also added some additional tests, bumped to Caddy v2.75, and refactored some interfaces.
If the MR(s) look okay, I will cut a release for them tomorrow, and your xcaddy
builds should work again when it pulls in this plugin.
@kmott #4 Looks good to me! Nice job on the test coverage.
FYI @sundbry new tagged version is available v0.1.0
, and should fix the issues you had. Thank you again for reporting the issue!
Hi @kmott, I was giving your module a try, and ran into this crash:
My config looks like this,
I am not sure why it's failing to parse that URL.