mywordpress-io / caddy-vault-storage

MIT License
2 stars 1 forks source link

The vault token is logged as INFO #3

Closed sundbry closed 10 months ago

sundbry commented 10 months ago

The vault token is being logged at INFO level!

Example:

{"level":"info","ts":1700070148.4857008,"logger":"tls","msg":"cleaning storage unit","description":"&{0xc000000e40 {https://vault.mydomain.net:8200 REDACTED_VAULT_TOKEN_here     kv caddy true <nil> <nil> }}"}
kmott commented 10 months ago

Interesting, what version of Caddy are you using, and how are you building the plugin? Can you show me your Caddy config, and command you are using to start Caddy?

sundbry commented 10 months ago

Hi @kmott, you can build my same image here using the Dockerfile: https://github.com/gnomatic-cloud/caddylb

I don't have my Caddyfile at hand, but its roughly

{ storage vault "https://vault” { token "secret” ... } }

sundbry commented 10 months ago

Come to think of it, this is possibly a side-effect of my changes in PR #2.

kmott commented 10 months ago

Okay, let me take a look at the MR, and make some adjustments, and I'll get back to you in a bit.

kmott commented 10 months ago

Hi @kmott, you can build my same image here using the Dockerfile: https://github.com/gnomatic-cloud/caddylb

I don't have my Caddyfile at hand, but its roughly

{ storage vault "https://vault” { token "secret” ... } }

@sundbry I cannot find your Caddyfile in that repo, please paste the full Caddyfile here so I can reproduce your problem.

kmott commented 10 months ago

I was able to find a Caddyfile and reproduce the problem. Closing this in favor of tracking the real issue in #2