search

mywot / chrome

WOT's Chrome extension
http://www.mywot.com/wiki/Chrome
GNU General Public License v3.0
8 stars 7 forks source link

Don't show warning screen immediately after rating site #16

Closed sorgoz closed 12 years ago

sorgoz commented 12 years ago

It annoys me everytime.

Is it made intentionally?

samitolvanen commented 12 years ago

Yes, it updates the warning screen immediately after you rate the site. The warning is shown if you rate the site poorly and hidden if you rate the site good. Probably the logic necessary to avoid showing the warning immediately after rating wouldn't be worth it. We definitely do want to immediately hide the warning in case of a good rating.

sorgoz commented 12 years ago

So,

  1. If site is rated poorly by WOT, but is rated good by user - hide warning.
  2. If site is rated good/unknown, but user rate it to red - ? (currently we show warning, I suggest to don't show it immediately)
samitolvanen commented 12 years ago

I feel it complicates the warning logic, but it can obviously be done. Would it work if we just set the warned flag in cache for sites after the user rates a site?

wot.cache.setflags(target, { warned: true });

Warnings are not shown for sites that have the warned flag set in the cache.

sorgoz commented 12 years ago

done (for chrome only). I'll file this issue to other browsers.