mywot / firefox-xul

WOT's current XUL-based Firefox extension
http://www.mywot.com/wiki/Firefox
GNU General Public License v3.0
2 stars 8 forks source link

Private browsing changes may break the add-on #27

Closed samitolvanen closed 11 years ago

samitolvanen commented 11 years ago

We use nsIPrivateBrowsingService here:

https://github.com/mywot/firefox-xul/blob/master/content/util.js#L307

This interface will be deprecated in Firefox 20:

https://developer.mozilla.org/en-US/docs/Updating_addons_broken_by_private_browsing_changes

It shouldn't break the add-on unless the user has tweaked a setting on the advanced settings page though, but if they have, the add-on won't work as expected and disable itself when in private browsing mode. We should fix this:

https://developer.mozilla.org/en-US/docs/Supporting_per-window_private_browsing