search

myxvisual / react-uwp

📱⌨ React Components that Implement Microsoft's UWP Design & Fluent Design.
https://react-uwp.com
MIT License
1.18k stars 78 forks source link

Convert DropDownMenu to select element #12

Closed renshenhe closed 7 years ago

renshenhe commented 7 years ago

Since DropDownMenu does not use <select /> element and <option /> element this does not allow the usage of keys making it difficult to locate a selection without reimplementing a value targeting handler event in DropDownMenu. I am unsure whether the intentions of the design were focused on limited number of values/options or an oversight when using an implementation of the TextField/TextBox component.

myxvisual commented 7 years ago

@renshenhe Sincerely, thanks for your feedback, I have recently used this library in two new projects, can really find some bugs, but I can not immediately fix these, because the new feature to change the code too much, this project temporarily only me, will take time to deal with bugs, I hope to make this project better and more efficient. I will try to get the components closer to the native web element.

myxvisual commented 7 years ago

@renshenhe Hi, i think best practice is to use select, which can give the component more flexibility.

links: Material-UI DropDownMenu Fabric DropDown Ant Design DropDown