search

myzhan / locust4j

Locust4j is a load generator for locust, written in Java.
MIT License
81 stars 30 forks source link

Switch to slf4j provided by the logback library #6

Closed vzhikserg closed 5 years ago

vzhikserg commented 5 years ago

The custom logging was substituted with the standard library for logging.

codecov-io commented 5 years ago

Codecov Report

Merging #6 into master will increase coverage by 0.38%. The diff coverage is 48.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage    77.7%   78.08%   +0.38%     
==========================================
  Files          20       19       -1     
  Lines         861      858       -3     
  Branches       82       80       -2     
==========================================
+ Hits          669      670       +1     
+ Misses        172      169       -3     
+ Partials       20       19       -1
Impacted Files Coverage Δ
...a/com/github/myzhan/locust4j/rpc/ZeromqClient.java 0% <0%> (ø) :arrow_up:
.../java/com/github/myzhan/locust4j/AbstractTask.java 16.66% <33.33%> (+4.9%) :arrow_up:
...ava/com/github/myzhan/locust4j/runtime/Runner.java 70.71% <38.88%> (+0.22%) :arrow_up:
...b/myzhan/locust4j/ratelimit/RampUpRateLimiter.java 92.45% <50%> (+0.14%) :arrow_up:
...ithub/myzhan/locust4j/taskset/WeighingTaskSet.java 57.69% <50%> (+1.69%) :arrow_up:
...n/java/com/github/myzhan/locust4j/utils/Utils.java 80% <50%> (+0.68%) :arrow_up:
...b/myzhan/locust4j/ratelimit/StableRateLimiter.java 94.44% <50%> (+0.15%) :arrow_up:
...n/java/com/github/myzhan/locust4j/stats/Stats.java 95.27% <66.66%> (+0.83%) :arrow_up:
...c/main/java/com/github/myzhan/locust4j/Locust.java 55.55% <77.77%> (+0.26%) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6f05393...7f89a85. Read the comment docs.

myzhan commented 5 years ago

@vzhikserg thanks for your contribution! I didn't use a logging library because I want to minimize the dependencies. Since we have added logback, we need to make sure that it works with any user code or logging configuraion.