Draft: Repeater DB changes

myzinsky / cloudLogOffline

An App as Offline Frontend for CloudLog

GNU Lesser General Public License v3.0

17 stars 7 forks source link

Draft: Repeater DB changes #109

Open dg0yt opened 4 months ago

dg0yt commented 4 months ago

For feedback. (The whole C++ file. I didn't optimize for a minimal diff but for a better structure.) In particular: caching. The download is app. 5 MB, and the server is taken several seconds to respond.

The class (or file) still has many responsibilities.

Model for QML view
Importer for repeater list
Network access
Positioning access and locator conversion

Positioning and locator conversion is used in the settings view, independent of the repeater list. I would suggest ot break it up a little bit. Individual concerns could also be tested in CI (locator conversion, JSON import).

dg0yt commented 4 months ago

With the current qmake project structure, it is not possible to add any tests: Each target must be in a separate directory, but the main target is already at the top level. I know how to move things around at the plain text file level, but I don't know the impact on future interactive project changes in Qt Creator.

myzinsky commented 4 months ago

Best would be if we move the project to cmake ...

dg0yt commented 4 months ago

Best would be if we move the project to cmake ...

Okay, I'm using CMake already since Qt5. It has some implications for generating bundle-style installations (ios and android app packages), and for IDE support (but I edit the cmake files directly).

dg0yt commented 3 weeks ago

Best would be if we move the project to cmake ...

Started in https://github.com/myzinsky/cloudLogOffline/pull/120.

myzinsky commented 3 weeks ago

Just tell me when I should merge it :-)

dg0yt commented 3 weeks ago

I'm about to bring it in mergeable state. It fixes #119 which really deserves somes priority.