search

mz-automation / lib60870.NET

Official repository for lib60870.NET an implementation of the IEC 60870-5-101/104 protocols in C#
https://www.mz-automation.de/communication-protocols/iec-60870-5-101-104-c-net-source-code-library/
GNU General Public License v3.0
122 stars 74 forks source link

Receiving an I or S frame while in STOPDT should shut down the connection #18

Closed gboor closed 3 years ago

gboor commented 3 years ago

According to spec, when you receive an I or S frame in STOPDT mode, the connection should be shut down as this is an error.

We ran into this issue today during a conformance test and found out that it's not something that can be handled outside the library, so I made these small changes.

mzillgith commented 3 years ago

Thanks. You are right.

In order to accept pull requests we need you to sign a contributor license agreement. For information please write to info@libiec61850.com

gboor commented 3 years ago

Thanks for the feedback, but it looks like this was committed into the repo anyway? I think this MR can be closed, or am I missing something?

mzillgith commented 3 years ago

Yes. I it can be closed. It was only a small change so I implemented quickly.