search

mzabriskie / react-disqus-thread

React Discus thread component
176 stars 65 forks source link

Update DisqusThread to work with (non-beta) react 16 #35

Open shawninder opened 6 years ago

shawninder commented 6 years ago

This PR is similar to https://github.com/mzabriskie/react-disqus-thread/pull/34 but it points to non-beta versions of react and react-dom

MrToph commented 6 years ago

I would really like to see this merged

saitejalingam commented 6 years ago

can someone merge this if it's already been approved?

h-dong commented 5 years ago

@neacsugeorge would it possible for you to merge this? Do you have permission?

h-dong commented 5 years ago

@shawninder If no one has permission to merge this in and release it to NPM. Do you mind releasing your fork to NPM under a different name? Thanks

shawninder commented 5 years ago

@h-dong If you think it's a good idea I can look into it. I'd like to first make another attempt at reaching the current owner to see if he or she might be willing to simply transfer ownership of the package...

Also, I'm no longer using this package myself so I may not be the best person to do this. Perhaps you would like to take this on yourself @h-dong?

In any case, if I do end up publishing this to npm (or acquiring ownership of the existing package), I would greatly appreciate help with maintenance. I can be pretty responsive and look at PRs and such but again since I don't use the package myself (currently), I may feel a little less confident in my testing and analysis.

In the meantime, I hope it's clear that anyone can use this right away simply by declaring a dependency directly on the github repo (rather than on the npm package). So in your package.json, instead of:

  "react-disqus-thread": "0.4.0"

you might use the following for example:

  "react-disqus-thread": "https://github.com/WaltzApp/react-disqus-thread.git"

Anyways, as I said, I'll look into it in the next few days and I'll post back here once I reach a decision.

h-dong commented 5 years ago

Hi @shawninder, thanks for getting back to me!

After posting my previous message, I already forked the repo and started playing around with it. But then I came across another project that worked for me https://github.com/disqus/disqus-react 😂 So I'm not in a rush for anything to be decided or this PR to be merged.