search

mzabriskie / react-disqus-thread

React Discus thread component
176 stars 65 forks source link

Reload disqus when invoking `componentDidUpdate` #9

Closed arunoda closed 8 years ago

arunoda commented 9 years ago

Sometimes when browsing though a set of article, (like using a sidebar) our component get updated. So, we need to show a different comment box. But it does not do it.

Here's the fix.

Review on Reviewable

mzabriskie commented 9 years ago

Why are you putting _disqusAdded on the window? Would be better to just add it to this.

arunoda commented 9 years ago

But it's possible to destroy a component altogether before the loading complete. On 2015 අගෝ 2, ඉරිදා at ප.ව. 11.12 Matt Zabriskie notifications@github.com wrote:

Why are you putting _disqusAdded on the window? Would be better to just add it to this.

— Reply to this email directly or view it on GitHub https://github.com/mzabriskie/react-disqus-thread/pull/9#issuecomment-127048875 .

hiddentao commented 9 years ago

+1 I need this too. Thanks @arunoda .

arunoda commented 8 years ago

Awesome.