search

mzahana / mavros_apriltag_tracking

This package implements methods to enable a PX4-powered multi-rotor to track a moving vehicle.
BSD 3-Clause "New" or "Revised" License
126 stars 34 forks source link

Removed bug from README-It doesn't work in the previous case. The sta… #7

Closed sahin52 closed 2 years ago

sahin52 commented 3 years ago

…rt_tracking.sh file is different.
I tried this out, it wasn't working, it took me a time(and cloning the repo) to understand the mistake.
I didn't try the version that I pushed here but it is now the same with the sh file.
The version I tried and working is: 

rostopic pub --once /uav1/mavros/mount_control/command mavros_msgs/MControl '{header: { seq: 0, stamp: {secs: 0, nsecs: 0}, frame_id: ""}, mode: 2, pitch: -45.0, roll: 0.0, yaw: 0.0, altitude: 0.0, latitude: 0.0, longitude: 0.0}'
sahin52 commented 3 years ago

I'd love to see you accept this pull request, it's been 4 months

mzahana commented 3 years ago

@sahin52 thank you very much for the pull request.

First, I don't understand what the issues exactly is/was. Can you please make title shorter and concise? Is the issue in any script, or just the README was not clear ?

sahin52 commented 2 years ago

without spaces, it does not work in command line. So I added the spaces at the starts of the lines. The 

      seq: 0
      stamp: {secs: 0, nsecs: 0}
      frame_id: ''

are subobjects of "header:. If the spaces are not given, they are becoming a main key value pair, but actually they are under header. For example the 

    mode: 2
    pitch: -90.0
    roll: 0.0

are not under header, so they don't have spaces as much as the seq, stamp and frame_id keys.

mzahana commented 2 years ago

Thanks @sahin52 !