search

mzanetti / kodimote

Kodimote is a remote control application for Kodi
GNU General Public License v3.0
20 stars 9 forks source link

Wrong size of playback control buttons on Jolla C #94

Open dikonov opened 6 years ago

dikonov commented 6 years ago

The kodimote [fork] by ade draws playback control buttons wrongly. Two of the buttons go offscreen. See rthe attached photo. Physical size of Jolla C screen is 110x62 mm.

cimg8353 Left Jolla C, Right Jolla 1. Both running the ade's fork version of kodimote.

dikonov commented 6 years ago

The new version 2.1.2-4 definitely looks better. However Jolla C has its own screen size and pixel density. The button size for Jolla C is now physically smaller than on Jolla 1.

Another issue is that TV show names and music metadata printed below the playlist items are too big to fit in the available space. Could they be made smaller?

cimg8367 cimg8370

dikonov commented 6 years ago

The new version correctly sizes the playback buttons (GOOD!) but The spacing of lists is way too large. It wastes about 30% of screen space. The truth is in between 2.1.3-1 and 2.1.3-2. jollac-too_wide

dikonov commented 6 years ago

2.1.3-3 Makes the pacing too tight again. See the picture. jollac-list spacing_too tight_v2 1 3-3

dikonov commented 6 years ago

2.1.3-5 Made the list spacing even WIIIIDEEEERR. jollac-even_wider

dikonov commented 6 years ago

Related history of changes in apps/sailfish/qml/pages/BrowserPage.qml

2.1.3-4 Final attempt to fix list item height jolla C 8days ago - HORRIBLY LARGE spaces between list items > MEDIUM

- property int itemHeight: browserPage.model && browserPage.model.thumbnailFormat === KodiModel.ThumbnailFormatPortrait ? (126 * appWindow.sizeRatio) : (92 * appWindow.sizeRatio)
+ property int itemHeight: browserPage.model && browserPage.model.thumbnailFormat === KodiModel.ThumbnailFormatPortrait ? (appWindow.smallScreen ? 200 : 126 * appWindow.sizeRatio) : (appWindow.smallScreen ? 320 : 92 * appWindow.sizeRatio)

2.1.3-3 Attempt to fix list item height jolla C 9 days - OVERLAPPING list items > HORRIBLY LARGE 

- property int itemHeight: browserPage.model && browserPage.model.thumbnailFormat === KodiModel.ThumbnailFormatPortrait ? (appWindow.smallestScreen? 126 : 126*2) : (appWindow.smallestScreen? 92 : 92*2)
+ property int itemHeight: browserPage.model && browserPage.model.thumbnailFormat === KodiModel.ThumbnailFormatPortrait ? (126 * appWindow.sizeRatio) : (92 * appWindow.sizeRatio)

2.1.3-2 Attempt to support jolla C (720p) resolution 11 days - MEDIUM (30%) unneeded spaces > OVERLAPPING 

- property int itemHeight: browserPage.model && browserPage.model.thumbnailFormat === KodiModel.ThumbnailFormatPortrait ? (appWindow.smallScreen? 126 : 126*2) : (appWindow.smallScreen? 92 : 92*2)
+ property int itemHeight: browserPage.model && browserPage.model.thumbnailFormat === KodiModel.ThumbnailFormatPortrait ? (appWindow.smallestScreen? 126 : 126*2) : (appWindow.smallestScreen? 92 : 92*2)

2.1.2-8 Scaled Jolla C back to Jolla 1 sizing 18 days - OVERLAPPING list items > MEDIUM

- property int itemHeight: browserPage.model && browserPage.model.thumbnailFormat === KodiModel.ThumbnailFormatPortrait ? (largeScreen? 126*2 : 126) : (largeScreen? 92*2 : 92)
+ property int itemHeight: browserPage.model && browserPage.model.thumbnailFormat === KodiModel.ThumbnailFormatPortrait ? (appWindow.smallScreen? 126 : 126*2) : (appWindow.smallScreen? 92 : 92*2)