Add more fields to CFP page

OnurOzayyy commented 7 years ago

Added more fields to models
revise the cfp template

mzdaniel commented 7 years ago

Thank you Onur. This is great! Couple of comments.

I tried to complete a cfp and cannot send it, meaning the data is not properly validated and stored. The cfp page was working before and stored the fields defined. You could try adding fields one by one and find out where is the issue that way.
Your PR has 3 commits and some redo things done in others. This makes changes hard to understand as the changes are not incremental. Could you squash all commits into one for this PR, or if you prefer 2 commits, one for the new fields and related backend logic, and another with the templates?
Lets not add tabs characters into the files on the repo. This will prevent git showing differences that are not relevant to the PR.

PirosB3 commented 7 years ago

@OnurOzayyy there are a few changes I'd like to address based on errors in the form. I'm just going to take initiative and fork off yours, let me know if you would like differently :)

mzdaniel commented 7 years ago

@PirosB3: why don't we concentrate in the backend changes and let Onur focus in the frontend? We can later bridge the frontend styling needs.

There is too many frontend concerns already here. If we all agree, let's tab this PR and work in a new one that focus in the forms and backend fields independently from the frontend changes.

PirosB3 commented 7 years ago

@OnurOzayyy please view my PR on your fork

mzdaniel / pybay_front_end

Add more fields to CFP page #8