mzdrale / pyubee

Simple library for getting stats from Ubee routers.
GNU General Public License v3.0
2 stars 4 forks source link

Not working Ubee EVW321B (Ziggo NL) #9

Closed Haggard closed 5 years ago

Haggard commented 5 years ago

Ubee EVW321B is not working with device_tracker

Traceback (most recent call last):

  File "/usr/local/lib/python3.7/site-packages/homeassistant/components/device_tracker/__init__.py", line 170, in async_setup_platform
    platform.get_scanner, hass, {DOMAIN: p_config})
  File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.7/site-packages/homeassistant/components/ubee/device_tracker.py", line 34, in get_scanner
    ubee = Ubee(host, username, password, model)
  File "/usr/local/lib/python3.7/site-packages/pyubee/__init__.py", line 91, in __init__
    raise LookupError('Unknown model')
LookupError: Unknown model
StevenLooman commented 5 years ago

Thank you for the issue. I'm hoping your model is mostly compatible with the EVW320B.

Some things you can test:

karrukola commented 5 years ago

Hello @StevenLooman, I too have that device at home and I think I managed to add the support for it; I have just raised the PR with my code.

I am not sure which evidence I have to provide. Please advise.

Also see attached RootDevice.txt

StevenLooman commented 5 years ago

Great work! v0.7 has been released already (courtesy @mzdrale). If you want integration into home assistant you'll have to create a PR there, upgrading the used version of the library, using this file.

mzdrale commented 5 years ago

Hey, I already created Home Assistant PR: #24477.

mzdrale commented 5 years ago

Thank you guys! I'm going to close this issue, since pyubee is working with EVW321B model now.