Closed mzechmeister closed 5 years ago
Currently, flux and error are rescaled when reading FOX extracted spectra, e.g.: https://github.com/mzechmeister/serval/blob/ea9abf2f679a4e76efc698691124aba75a259fb4/src/read_spec.py#L832-L833 The reason it that a threshold to mask flux below or close to zero in the template (times the polynomial) is hardcoded https://github.com/mzechmeister/serval/blob/ea9abf2f679a4e76efc698691124aba75a259fb4/src/serval.py#L358-L359 or https://github.com/mzechmeister/serval/blob/ea9abf2f679a4e76efc698691124aba75a259fb4/src/serval.py#L366
It would be better to make the threshold flexible.
Currently, flux and error are rescaled when reading FOX extracted spectra, e.g.: https://github.com/mzechmeister/serval/blob/ea9abf2f679a4e76efc698691124aba75a259fb4/src/read_spec.py#L832-L833 The reason it that a threshold to mask flux below or close to zero in the template (times the polynomial) is hardcoded https://github.com/mzechmeister/serval/blob/ea9abf2f679a4e76efc698691124aba75a259fb4/src/serval.py#L358-L359 or https://github.com/mzechmeister/serval/blob/ea9abf2f679a4e76efc698691124aba75a259fb4/src/serval.py#L366
It would be better to make the threshold flexible.