search

mzechmeister / serval

calculate radial velocities from stellar spectra
MIT License
36 stars 9 forks source link

ValueError: Floating point nan values are not allowed in FITS headers. #24

Closed mzechmeister closed 5 years ago

mzechmeister commented 5 years ago

When targ.rv is nan, the error is generated in https://github.com/mzechmeister/serval/blob/ea9abf2f679a4e76efc698691124aba75a259fb4/src/serval.py#L1501

Its handling likely depends on the astropy fits version.

Workarounds are:

  1. uncomment the line or
  2. nan-check 
    if not np.isnan(targ.rv):
mzechmeister commented 5 years ago

Fixed in e52fcf587bc272d93d7012f9cb735754be7c1d88:

@@ -1477,7 +1492,10 @@ def serval(*argv):
          spt.header['HIERARCH SERVAL COADD NUM'] = (nspecok, 'number of spectra used for coadd')
-         spt.header['HIERARCH SERVAL TARG RV'] = (targ.rv, '[km/s] RV from targ.cvs')
+         if np.isfinite(targ.rv):
+            spt.header['HIERARCH SERVAL TARG RV'] = (targ.rv, '[km/s] RV from targ.cvs')
+         else:
+            spt.header['HIERARCH SERVAL TARG RV'] = (targrv, '[km/s] RV from targrv')

          # Oversampled template
          write_template(tpl, ff, ww, spt.header, hdrref='', clobber=1)